linux-kernel - Re: [PATCH -v4] x86: only load initrd above 4g on second try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5408D299.5000300@zytor.com>
Date:	Thu, 04 Sep 2014 13:59:05 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Matt Fleming <matt@...sole-pimps.org>,
	Yinghai Lu <yinghai@...nel.org>
CC:	Matt Fleming <matt.fleming@...el.com>,
	Ingo Molnar <mingo@...hat.com>,
	Mantas Mikulėnas <grawity@...il.com>,
	Anders Darander <anders@...rgestorm.se>,
	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -v4] x86: only load initrd above 4g on second try

On 09/04/2014 03:01 AM, Matt Fleming wrote:
> On Wed, 03 Sep, at 09:50:07PM, Yinghai Lu wrote:
>> Mantas found that after commit 4bf7111f5016 ("x86/efi: Support initrd
>> loaded above 4G"), the kernel freezes at the earliest possible moment
>> when trying to boot via UEFI on Asus laptop.
>>
>> Revert to old way to load initrd under 4G on first try,
>> second try will use above 4G buffer when initrd is too big
>> and does not fit under 4G.
>>
>> -v2: add print out for second try, and print out files buf address.
>> -v3: can not snprintf
>> -v4: drop address print out for files buf
>>
>> Reported-by: Mantas Mikulėnas <grawity@...il.com>
>> Tested-by: Anders Darander <anders@...rgestorm.se>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>>
>> ---
>>  arch/x86/boot/compressed/eboot.c |   18 +++++++++++-------
>>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> Thanks, I've picked this up and expanded on the commit message because a
> lot of useful information was discussed on the mailing list that we
> should definitely include.
> 
>   http://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/commit/?h=urgent&id=b524e05df6d466af2f7eea1f044369109e48e641
> 

I am fine with this patch, but at the same time I do want to note that
there is an alternative to double-buffer the patch and/or (if that
applies to the buggy BIOS) round up the size of the target buffer.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/