linux-kernel - Re: [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C5C2C5C4-25F9-4D1A-967E-7396270A3B24@cam.ac.uk>
Date:	Thu, 4 Sep 2014 23:01:43 +0100
From:	Anton Altaparmakov <aia21@....ac.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Theodore Ts'o <tytso@....edu>, Al Viro <viro@...IV.linux.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

Hi Linus,

No-one has objected to the below patch I sent you over two weeks ago.

Would you please apply it?

If you would like it to go through for example Al or Andrew please let me know...

Thanks a lot in advance!

Best regards,

	Anton

On 21 Aug 2014, at 11:09, Anton Altaparmakov <aia21@....ac.uk> wrote:

> This patch changes sync_filesystem() to be EXPORT_SYMBOL().
> 
> The reason this is needed is that starting with 3.15 kernel, due to 
> Theodore Ts'o's commit 02b9984d640873b7b3809e63f81a0d7e13496886, "fs: push 
> sync_filesystem() down to the file system's remount_fs()", all file 
> systems that have dirty data to be written out need to call 
> sync_filesystem() from their ->remount_fs() method when remounting 
> read-only.
> 
> As this is now a generically required function rather than an internal 
> only function it should be EXPORT_SYMBOL() so that all file systems can
> call it.
> 
> Signed-off-by: Anton Altaparmakov <aia21@...tab.net>
> ---
> 
> Hi Linus,
> 
> Can you please apply this patch for inclusion into 3.17?  Explanation is 
> above.
> 
> Thanks a lot in advance!
> 
> PS. I hope Pine does not mess up the whitespace of the patch!
> 
> Best regards,
> 
> 	Anton
> -- 
> Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
> University of Cambridge Information Services, Roger Needham Building
> 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
> 
> --- linux/fs/sync.c	2014-08-21 10:30:26.000000000 +0100
> +++ linux/fs/sync.c	2014-08-21 10:30:47.000000000 +0100
> @@ -65,7 +65,7 @@ int sync_filesystem(struct super_block *
> 		return ret;
> 	return __sync_filesystem(sb, 1);
> }
> -EXPORT_SYMBOL_GPL(sync_filesystem);
> +EXPORT_SYMBOL(sync_filesystem);
> 
> static void sync_inodes_one_sb(struct super_block *sb, void *arg)
> {

-- 
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/