linux-kernel - Re: [PATCHv4 2/2] dt-bindings: regulator: Add regulator suspend state for PM state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140904225303.GY29327@sirena.org.uk>
Date:	Thu, 4 Sep 2014 23:53:03 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	lgirdwood@...il.com, grant.likely@...aro.org, robh+dt@...nel.org,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCHv4 2/2] dt-bindings: regulator: Add regulator suspend
 state for PM state

On Mon, Aug 18, 2014 at 03:27:03PM +0900, Chanwoo Choi wrote:

> +- regulator-initial-state: initial state for suspend state, cnd set initial
> +  state among following defined suspend states:
> +  <3>: PM_SUSPEND_MEM - Setup regulator according to regulator-state-mem
> +  <4>: PM_SUSPEND_MAX - Setup regulator according to regulator-state-disk

Please add defines for these in include/dt-bindings.  Probably worth
pointing out that if absent the state is the hardware default (same for
most of these.

> +- regulator-state-[mem/disk] node has following common properties:
> +	- regulator-volt: voltage consumers may set in suspend state.

We use -uV rather than -volt in other bits of the bindings.

> +	- regulator-on-in-suspend: regulator should be on in suspend state.
> +	- regulator-off-in-suspend: regulator should be off in suspend state.
> +	If node don't include regulator-[on/off]-in-suspend, can't change
> +	regulator state in suspend mode and only should sustain the regulator
> +	state of normal state.

Probably better to say that the OS will not manage the state here -
otherwise we have to explicitly override any hardware default that's
there which drivers and the core don't do right now.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)