linux-kernel - Re: [RFC v2 6/6] pata_marvell: use async probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54095F65.6010405@gmail.com>
Date:	Fri, 05 Sep 2014 12:59:49 +0600
From:	"Alexander E. Patrakov" <patrakov@...il.com>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	gregkh@...uxfoundation.org, dmitry.torokhov@...il.com,
	falcon@...zu.com, tiwai@...e.de, tj@...nel.org,
	arjan@...ux.intel.com
CC:	linux-kernel@...r.kernel.org, oleg@...hat.com, hare@...e.com,
	akpm@...ux-foundation.org, penguin-kernel@...ove.sakura.ne.jp,
	joseph.salisbury@...onical.com, bpoirier@...e.de,
	santosh@...lsio.com, "Luis R. Rodriguez" <mcgrof@...e.com>,
	linux-ide@...r.kernel.org,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Subject: Re: [RFC v2 6/6] pata_marvell: use async probe

05.09.2014 12:37, Luis R. Rodriguez пишет:
> From: "Luis R. Rodriguez" <mcgrof@...e.com>
>
> Alexander reported that on his Sony VAIO VPCZ23A4R laptop
> experiences long delays on boot when connected to its dock
> station on pre 3.9 kernels but anything after 3.9 will cause
> the device to not be detected at all ending with:
>
> [   38.065673] pata_marvell 0000:1a:00.0: no available native port
> [   38.065769] pata_acpi 0000:1a:00.0: no available native port

I object to this commit message, it is based on outdated information and 
is due to a different bug that was fixed in 3.10 as a last-minute fix. 
Modern kernels just experience long delays during boot.

> This laptop has a Marvell 88SE6121 SATA II Controller [11ab:6121]
> and a BluRay writer attached. The reason for the delays are
> caused by SRST errors and the link being slow to respond.
> The pata_marvell driver is a simple libata wrapper so the
> real required changes need to be made on libata however not
> many folks are around and available anymore with intimate
> knowledge and experience with these devices. Alexander notes
> that it may be that *any* ATA BMDMA controller that fails to
> respond to an identify command until a reset or other device
> poking might suffer from similar fate, this needs to be
> investigated further. Using async probe the issue caused
> by systemd killing the driver after taking over 30 seconds
> on probe.
>
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=59581
>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: linux-ide@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Benjamin Poirier <bpoirier@...e.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: patrakov@...il.com
> Reported-by: "Alexander E. Patrakov" <patrakov@...il.com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com>
> ---
>   drivers/ata/pata_marvell.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c
> index ae9feb1..6a543b9 100644
> --- a/drivers/ata/pata_marvell.c
> +++ b/drivers/ata/pata_marvell.c
> @@ -175,6 +175,7 @@ static struct pci_driver marvell_pci_driver = {
>   	.suspend		= ata_pci_device_suspend,
>   	.resume			= ata_pci_device_resume,
>   #endif
> +	.driver.async_probe = true,
>   };
>
>   module_pci_driver(marvell_pci_driver);
>


-- 
Alexander E. Patrakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/