linux-kernel - Re: [PATCH] pinctrl: bcm281xx: Add remove function to pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbunsVd5Y2aiS6dXAgD6DpyFe8ukm12n7YM97M=q7X+mQ@mail.gmail.com>
Date:	Fri, 5 Sep 2014 10:03:13 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sherman Yin <syin@...adcom.com>
Subject: Re: [PATCH] pinctrl: bcm281xx: Add remove function to pinctrl_unregister

On Sat, Aug 30, 2014 at 6:19 PM, Pramod Gurav
<pramod.gurav@...rtplayin.com> wrote:

> This patch adds a remove function in platform_driver to pinctrl_unregister
> for clean unloading.
> This makes local struct pinctrl_dev a part of struct bcm281xx_pinctrl_data to
> be accessed from pdev in remove function.
>
> CC: Sherman Yin <syin@...adcom.com>
> CC: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>

Since this driver is a "bool" in Kconfig, it is not loaded as a module
and .remove() is never called.

So this is unnecessary.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/