linux-kernel - Re: [PATCH v2 1/4] arm64, thunder: Add Kconfig option for Cavium Thunder SoC Family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140905093239.GC30401@n2100.arm.linux.org.uk>
Date:	Fri, 5 Sep 2014 10:32:40 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Robert Richter <rric@...nel.org>
Cc:	Will Deacon <will.deacon@....com>,
	Mark Rutland <mark.rutland@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Catalin Marinas <catalin.marinas@....com>,
	Olof Johansson <olof@...om.net>,
	Robert Richter <rrichter@...ium.com>,
	Radha Mohan Chintakuntla <rchintakuntla@...ium.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] arm64, thunder: Add Kconfig option for Cavium
	Thunder SoC Family

On Fri, Sep 05, 2014 at 09:46:42AM +0200, Robert Richter wrote:
> From: Radha Mohan Chintakuntla <rchintakuntla@...ium.com>
> 
> Increase maximum numbers of cpus to 32. This relates to current
> maximal possible cpu number. Increasing this to 64 cpus will be a
> separate patch not part of this enablement patches.
> 
> Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@...ium.com>
> Signed-off-by: Robert Richter <rrichter@...ium.com>
> ---
>  arch/arm64/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index fd4e81a4e1ce..77fb82b0f684 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -134,6 +134,11 @@ source "kernel/Kconfig.freezer"
>  
>  menu "Platform selection"
>  
> +config ARCH_THUNDER
> +	bool "Cavium Inc. Thunder SoC Family"
> +	help
> +	  This enables support for Cavium's Thunder Family of SoCs.
> +
>  config ARCH_VEXPRESS
>  	bool "ARMv8 software model (Versatile Express)"
>  	select ARCH_REQUIRE_GPIOLIB
> @@ -256,6 +261,7 @@ config NR_CPUS
>  	range 2 32
>  	depends on SMP
>  	# These have to remain sorted largest to smallest
> +	default "32" if ARCH_THUNDER
>  	default "8"

Why do you need ARCH_THUNDER?  If it's just to change this default,
please don't bother - we don't do this kind of thing on x86, so why
should it be done here?  Just ensure that NR_CPUS is appropriately
adjusted.  Alternatively, look at how x86 deals with this (with
X86_BIGSMP / MAXSMP).

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/