linux-kernel - Re: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201409051338.40988@pali>
Date:	Fri, 5 Sep 2014 13:38:40 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Russell King <linux@....linux.org.uk>
Cc:	Santosh Shilimkar <santosh.shilimkar@...com>,
	Will Deacon <will.deacon@....com>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Sebastian Reichel <sre@...ian.org>,
	Pavel Machek <pavel@....cz>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Rob Herring <robherring2@...il.com>,
	Fabio Estevam <festevam@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>
Subject: Re: [PATCH] ARM: /proc/cpuinfo: Use DT machine name when possible

On Wednesday 18 June 2014 18:54:24 Pali Rohár wrote:
> Machine name from board description is some generic name on DT
> kernel. DT provides machine name property which is specific
> for board, so use it instead generic one when possible.
> 
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> ---
>  arch/arm/kernel/setup.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 8a16ee5..fbc7b4f 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -875,10 +875,13 @@ void __init setup_arch(char **cmdline_p)
> 
>  	setup_processor();
>  	mdesc = setup_machine_fdt(__atags_pointer);
> -	if (!mdesc)
> +	if (mdesc)
> +		machine_name = of_flat_dt_get_machine_name();
> +	else
>  		mdesc = setup_machine_tags(__atags_pointer,
> __machine_arch_type); machine_desc = mdesc;
> -	machine_name = mdesc->name;
> +	if (!machine_name)
> +		machine_name = mdesc->name;
> 
>  	if (mdesc->reboot_mode != REBOOT_HARD)
>  		reboot_mode = mdesc->reboot_mode;

So, do you really want to break userspace which reading file 
/proc/cpuinfo (after migration from boardcode --> DT)?

I still do not see reason for that. And only this one file is 
problematic...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)