lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 04 Sep 2014 18:35:13 -0700 From: Mike Turquette <mturquette@...aro.org> To: Chris Zhong <zyw@...k-chips.com>, dianders@...omium.org, heiko@...ech.de Cc: robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, sameo@...ux.intel.com, lee.jones@...aro.org, lgirdwood@...il.com, a.zummo@...ertech.it, akpm@...ux-foundation.org, broonie@...nel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com, grant.likely@...aro.org, hl@...k-chips.com, huangtao@...k-chips.com, cf@...k-chips.com, zhangqing@...k-chips.com, xxx@...k-chips.com, olof@...om.net, sonnyrao@...omium.org, dtor@...omium.org, javier.martinez@...labora.co.uk, kever.yang@...k-chips.com, "Chris Zhong" <zyw@...k-chips.com> Subject: Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808 Quoting Chris Zhong (2014-09-03 18:12:38) > +static int rk808_clkout1_is_prepared(struct clk_hw *hw) > +{ > + return 1; > +} > + <snip> > +static const struct clk_ops rk808_clkout1_ops = { > + .is_prepared = rk808_clkout1_is_prepared, > + .recalc_rate = rk808_clkout_recalc_rate, > +}; Hi Chris, I do not see a need clkout1 to have a .is_prepared callback. You should be fine only having a .recalc_rate. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists