linux-kernel - Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1409918621.30155.90.camel@intel.com>
Date:	Fri, 5 Sep 2014 12:03:41 +0000
From:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:	"Chen, Alvin" <alvin.chen@...el.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	"sebastian@...akpoint.cc" <sebastian@...akpoint.cc>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	"gnurou@...il.com" <gnurou@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"dvhart@...ux.intel.com" <dvhart@...ux.intel.com>,
	"atull@...nsource.altera.com" <atull@...nsource.altera.com>
Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce

On Fri, 2014-09-05 at 09:35 +0000, Chen, Alvin wrote:
> > Subject: Re: [PATCH 2/3 v2] GPIO: gpio-dwapb: Support Debounce
> > 
> > On Fri, 2014-09-05 at 07:53 -0700, Weike Chen wrote:
> > > This patch enables 'debounce' for the designware GPIO, and it is based
> > > on Josef Ahmad's previous work.
> > 
> > Can we split dwapb_read/write introducing and changing from this patch to a
> > separate one?
> > 
> Since the 'debounce' feature also needs read/write, if we splite this patch, then for 'debounce',
> One patch use readl/writel, and another patch change to dwapb_read/write. It seems duplicate since
> the previous patch use readl/writel and the fllowing one change it immediately.
> Since this patch is small, could we just make them together? How do you think?

Make the dwapb_writel/readl patch goes first in the series.

-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.