linux-kernel - Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140908105307.GF26030@arm.com>
Date:	Mon, 8 Sep 2014 11:53:07 +0100
From:	Will Deacon <will.deacon@....com>
To:	"behanw@...verseincode.com" <behanw@...verseincode.com>
Cc:	"anderson@...hat.com" <anderson@...hat.com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	"cl@...ux.com" <cl@...ux.com>,
	"cov@...eaurora.org" <cov@...eaurora.org>,
	"jays.lee@...sung.com" <jays.lee@...sung.com>,
	"msalter@...hat.com" <msalter@...hat.com>,
	"sandeepa.prabhu@...aro.org" <sandeepa.prabhu@...aro.org>,
	"srivatsa.bhat@...ux.vnet.ibm.com" <srivatsa.bhat@...ux.vnet.ibm.com>,
	"steve.capper@...aro.org" <steve.capper@...aro.org>,
	Sudeep Holla <Sudeep.Holla@....com>,
	"takahiro.akashi@...aro.org" <takahiro.akashi@...aro.org>,
	"Vijaya.Kumar@...iumnetworks.com" <Vijaya.Kumar@...iumnetworks.com>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"acme@...nel.org" <acme@...nel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Marc Zyngier <Marc.Zyngier@....com>,
	Matthew Leach <Matthew.Leach@....com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"olof@...om.net" <olof@...om.net>,
	"paulus@...ba.org" <paulus@...ba.org>,
	Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with
 clang

On Sat, Sep 06, 2014 at 12:24:20AM +0100, behanw@...verseincode.com wrote:
> From: Mark Charlebois <charlebm@...il.com>
> 
> Fix variable types for 64-bit inline assembly.
> 
> This patch now works with both gcc and clang.

Really? This looks like something the clang needs to do better on, as I
really don't see people adding these casts to future code. They're ugly and
redundant (or GCC).

This hunk:

> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index c555672..6894ef3 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -94,7 +94,7 @@ static int __init early_cachepolicy(char *p)
>  	 */
>  	asm volatile(
>  	"	mrs	%0, mair_el1\n"
> -	"	bfi	%0, %1, #%2, #8\n"
> +	"	bfi	%0, %1, %2, #8\n"
>  	"	msr	mair_el1, %0\n"
>  	"	isb\n"
>  	: "=&r" (tmp)

also looks fishy. Does gas accept that without the '#' prefix?

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/