linux-kernel - Re: [PATCH 2/3] staging: lustre: fix pointer whitespace style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410176264.12560.3.camel@joe-AO725>
Date:	Mon, 08 Sep 2014 04:37:44 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Spencer Baugh <sbaugh@...rew.cmu.edu>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	gregkh@...uxfoundation.org,
	Hongchao Zhang <hongchao.zhang@...el.com>,
	Niu Yawei <yawei.niu@...el.com>,
	Alex Zhuravlev <alexey.zhuravlev@...el.com>,
	open list <linux-kernel@...r.kernel.org>,
	Oleg Drokin <oleg.drokin@...el.com>
Subject: Re: [PATCH 2/3] staging: lustre: fix pointer whitespace style

On Mon, 2014-09-08 at 13:32 +0300, Dan Carpenter wrote:
> On Sat, Sep 06, 2014 at 11:19:03AM -0700, Joe Perches wrote:
> > Indexing a string array with an enum is generally unsafe.
> > I think it better to use a switch/case like:
> The reverse side of that argument is that switch statements are slower
> and uglier.

Uglier is true, safer is true too.
Slower depends.
Sometimes the actual code is identical.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/