linux-kernel - Re: [RFC v3 2/2] usb: phy: Temporarily hold timed wakeup source on charger and disconnect events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140908133948.GI22409@saruman.home>
Date:	Mon, 8 Sep 2014 08:39:49 -0500
From:	Felipe Balbi <balbi@...com>
To:	Kiran Kumar Raparthy <kiran.kumar@...aro.org>
CC:	<linux-kernel@...r.kernel.org>,
	Todd Poynor <toddpoynor@...gle.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [RFC v3 2/2] usb: phy: Temporarily hold timed wakeup source on
 charger and disconnect events

Hi,

On Mon, Sep 08, 2014 at 03:40:49PM +0530, Kiran Kumar Raparthy wrote:
> From: Todd Poynor <toddpoynor@...gle.com>
> 
> usb: phy: Temporarily hold timed wakeup source on charger and disconnect
> events
> 
> It temporarily holds a timed wakeup source on USB disconnect events, to allow
> the rest of the system time to react to the USB disconnection (dropping host
> sessions, updating charger status, etc.) prior to re-allowing suspend
> 
> Cc: Felipe Balbi <balbi@...com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-usb@...r.kernel.org
> Cc: Android Kernel Team <kernel-team@...roid.com>
> Cc: John Stultz <john.stultz@...aro.org>
> Cc: Sumit Semwal <sumit.semwal@...aro.org>
> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
> [kiran: Added context to commit message and
> addressed community feedback]
> Signed-off-by: Kiran Raparthy <kiran.kumar@...aro.org>
> ---
> v3:
> * Modified the commit log.
> * Remove indirect function usb_temporary_hold_wsource and call
>   __pm_wakeup_even directly.
> 
> v2:
> * Implement usb_temporary_hold_wsource function in phy.
> 
> v1:
> * Removed the refactoring logic from this integrated into main driver code.
> 
> RFC:
> * Integrated the refactoring logic and logic to hold wakeupsource
>   temporarily.
> 
>  drivers/usb/phy/otg-wakeupsource.c | 3 ++-
>  include/linux/usb/phy.h            | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/otg-wakeupsource.c b/drivers/usb/phy/otg-wakeupsource.c
> index d9a1720..7bc9657 100644
> --- a/drivers/usb/phy/otg-wakeupsource.c
> +++ b/drivers/usb/phy/otg-wakeupsource.c
> @@ -47,7 +47,8 @@ static void otgws_handle_event(struct usb_phy *otgws_xceiv, unsigned long event)
>  	case USB_EVENT_NONE:
>  	case USB_EVENT_ID:
>  	case USB_EVENT_CHARGER:
> -		__pm_relax(&otgws_xceiv->wsource);
> +		__pm_wakeup_event(&otgws_xceiv->wsource,
> +				msecs_to_jiffies(TEMPORARY_HOLD_TIME));

this was introduced by patch 1, why don't you merge this with that
patch? This is another comment that I have already provided. Why are you
ignoring my comments ? At a minimum, explain why are you ignoring them.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)