linux-kernel - Re: [PATCH] Staging: wlan-ng: Remove redundant break/goto statements in hfa384x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410184074.12560.6.camel@joe-AO725>
Date:	Mon, 08 Sep 2014 06:47:54 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ilja Sidoroff <ilja.sidoroff@....fi>
Cc:	greg@...ah.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: Remove redundant break/goto
 statements in hfa384x_usb.c

On Mon, 2014-09-08 at 15:48 +0300, Ilja Sidoroff wrote:
> This patch removes redundant goto or break statements in hfa384x_usb.c as found by checkpatch.pl
[]
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
[]
> @@ -3528,7 +3528,6 @@ static void hfa384x_usbin_rx(wlandevice_t *wlandev, struct sk_buff *skb)
>  		netdev_warn(hw->wlandev->netdev, "Received frame on unsupported port=%d\n",
>  			    HFA384x_RXSTATUS_MACPORT_GET(
>  				    usbin->rxfrm.desc.status));
> -		goto done;
>  		break;
>  	}

Better still to change the other use of "goto done" to
"break" and then remove the done label altogether.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/