linux-kernel - Re: [PATCH] Fix add missing include guard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140908061552.GQ19379@twins.programming.kicks-ass.net>
Date:	Mon, 8 Sep 2014 08:15:52 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Anand Moon <moon.linux@...oo.com>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix add missing include guard

On Sun, Sep 07, 2014 at 09:42:36PM +0530, Anand Moon wrote:
> If a header file happens to be included twice, the compiler will process
> its contents twice. This is very likely to cause an error, e.g. when the
> compiler sees the same structure definition twice. Even if it does not,
> it will certainly waste time.



> --- a/kernel/locking/lockdep_states.h
> +++ b/kernel/locking/lockdep_states.h
> @@ -4,6 +4,12 @@
>   * please update XXX_LOCK_USAGE_STATES in include/linux/lockdep.h whenever
>   * you add one, or come up with a nice dynamic solution.
>   */
> +
> +#ifndef __LOCKDEPSTATE_H__
> +#define __LOCKDEPSTATE_H__
> +
>  LOCKDEP_STATE(HARDIRQ)
>  LOCKDEP_STATE(SOFTIRQ)
>  LOCKDEP_STATE(RECLAIM_FS)
> +
> +#endif /* __LOCKDEPSTATE_H__ */


That file is actually designed to be included multiple times; you
clearly didn't understand what you were doing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/