linux-kernel - Re: [PATCH v2] [media]: sn9c20x.c: fix checkpatch error: that open brace { should be on the previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140908151851.GA23663@sudip-PC>
Date:	Mon, 8 Sep 2014 20:48:51 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Morgan Phillips <winter2718@...il.com>
Cc:	brijohn@...il.com, hdegoede@...hat.com, m.chehab@...sung.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] [media]: sn9c20x.c: fix checkpatch error: that open
 brace { should be on the previous line

On Mon, Sep 08, 2014 at 09:55:58AM -0500, Morgan Phillips wrote:
> Change array initialization format to fix style error.
> 	from:
> 		u8 foo[] =
> 			{1, 2, 3};
> 	to:
checkpatch is giving a warning here , but looks like a false positive.

thanks
sudip

> 		u8 foo[] = {
> 			1, 2, 3
> 		};
> 
> Signed-off-by: Morgan Phillips <winter2718@...il.com>
> ---
>  Changes since v2:
>    * adds a more verbose commit message
> 
>  drivers/media/usb/gspca/sn9c20x.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/usb/gspca/sn9c20x.c b/drivers/media/usb/gspca/sn9c20x.c
> index 41a9a89..95467f0 100644
> --- a/drivers/media/usb/gspca/sn9c20x.c
> +++ b/drivers/media/usb/gspca/sn9c20x.c
> @@ -1787,8 +1787,9 @@ static int sd_init(struct gspca_dev *gspca_dev)
>  	struct sd *sd = (struct sd *) gspca_dev;
>  	int i;
>  	u8 value;
> -	u8 i2c_init[9] =
> -		{0x80, sd->i2c_addr, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03};
> +	u8 i2c_init[9] = {
> +		0x80, sd->i2c_addr, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03
> +	};
>  
>  	for (i = 0; i < ARRAY_SIZE(bridge_init); i++) {
>  		value = bridge_init[i][1];
> @@ -2242,8 +2243,9 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev,
>  {
>  	struct sd *sd = (struct sd *) gspca_dev;
>  	int avg_lum, is_jpeg;
> -	static const u8 frame_header[] =
> -		{0xff, 0xff, 0x00, 0xc4, 0xc4, 0x96};
> +	static const u8 frame_header[] = {
> +		0xff, 0xff, 0x00, 0xc4, 0xc4, 0x96
> +	};
>  
>  	is_jpeg = (sd->fmt & 0x03) == 0;
>  	if (len >= 64 && memcmp(data, frame_header, 6) == 0) {
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/