linux-kernel - Re: [PATCH 4/4] staging: ozwpan: use kmalloc_array over kmalloc with multiply

Open Source and information security mailing list archives

Message-ID: <20140908063852.GA3578@distanz.ch>
Date:	Mon, 8 Sep 2014 08:38:52 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	anicoara <anicoara@...terloo.ca>
Cc:	shigekatsu.tateno@...el.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: ozwpan: use kmalloc_array over kmalloc with
 multiply

Your From: line does not contain a real name and does not match your
Signed-off-by line, please check your e-mail client settings.

On 2014-09-07 at 20:28:25 +0200, anicoara <anicoara@...terloo.ca> wrote:

No changelog text? Please add a short notice, describing why this change
is done.

> Signed-off-by: Adrian Nicoara <anicoara@...terloo.ca>
> ---
> Patch submitted as part of the Eudyptula challenge.
> 
>  drivers/staging/ozwpan/ozhcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
> index ba2168f..4cfe56e 100644
> --- a/drivers/staging/ozwpan/ozhcd.c
> +++ b/drivers/staging/ozwpan/ozhcd.c
> @@ -1315,7 +1315,7 @@ static int oz_build_endpoints_for_config(struct usb_hcd *hcd,
>  	if (num_iface) {
>  		struct oz_interface *iface;
> 
> -		iface = kmalloc(num_iface*sizeof(struct oz_interface),
> +		iface = kmalloc_array(num_iface, sizeof(struct oz_interface),
>  				mem_flags | __GFP_ZERO);

The line above should be adjusted to match the opening parenthesis.

>  		if (!iface)
>  			return -ENOMEM;
> --
> 2.0.1
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives