linux-kernel - Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of context imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140908172454.GA11205@kroah.com>
Date:	Mon, 8 Sep 2014 10:24:54 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Romer, Benjamin M" <Benjamin.Romer@...sys.com>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"Kershner, David A" <David.Kershner@...sys.com>,
	*S-Par-Maintainer <SParMaintainer@...sys.com>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of
 context imbalance

On Mon, Sep 08, 2014 at 12:10:55PM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> > Traditionally, you would respond with a:
> > 	Acked-by: Developer Name <email@...ress>
> > so I can add it to the patch.
> > 
> > Care to do that here?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Of course. :)
> 
> Acked-by: Benjamin Romer <benjamin.romer@...sys.com>
> 
> Should I do this instead of Tested-by and Signed-off-by, in the future?

If you test it, do a tested-by.

If you sign off on it (i.e. it flows through you to me), then a
signed-off is correct.

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/