linux-kernel - Re: [Patch v4 04/16] ACPI: Rename processor_core.c as apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1537817.rgZoClELVE@vostro.rjw.lan>
Date:	Mon, 08 Sep 2014 23:00:14 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Hanjun Guo <hanjun.guo@...aro.org>
Cc:	Jiang Liu <jiang.liu@...ux.intel.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Yinghai Lu <yinghai@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Grant Likely <grant.likely@...aro.org>,
	Len Brown <lenb@...nel.org>,
	Robert Moore <robert.moore@...el.com>,
	Lv Zheng <lv.zheng@...el.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tony Luck <tony.luck@...el.com>,
	Joerg Roedel <joro@...tes.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [Patch v4 04/16] ACPI: Rename processor_core.c as apic_id.c

On Monday, September 08, 2014 08:51:31 PM Hanjun Guo wrote:
> Hi Gerry, Rafael,
> 
> On 2014年09月08日 06:37, Rafael J. Wysocki wrote:
> > On Thursday, August 28, 2014 10:22:29 AM Jiang Liu wrote:
> >> Now all code in processor_core.c is APIC ID related, so rename it as
> >> apic_id.c. Later IOAPIC ID related code will be added into apic_id.c.
> > Actually, I'm not sure about this one.
> >
> > Renames like this make it difficult to backport things in general
> > and kind of break "git blame", so do we have to do that?
> >
> > What's wrong with leaving the name as is and adding a comment
> > about the contents being related to IOAPIC ID?
> 
> It will be thankful for not renaming the file into apic_id.c, because apic id is x86 specific,
> and platform like ARM will also add some code to get cpu hardware id via GICC structure
> in MADT table in that file, apic id is not a generic name for both x86 and ARM, I prefer to
> keep it as it is :)

Well, that's a good argument too.

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/