linux-kernel - [PATCH] staging/rtl8192u - check for skb alloc failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <75005.1410214188@turing-police.cc.vt.edu>
Date:	Mon, 08 Sep 2014 18:09:48 -0400
From:	Valdis Kletnieks <Valdis.Kletnieks@...edu>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Paul Bolle <pebolle@...cali.nl>
cc:	Jerry Chuang <jerry-chuang@...ltek.com>,
	devel@...verdev.osuosl.org, nick <xerofoify@...il.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] staging/rtl8192u - check for skb alloc failure

It's possible for dev_alloc_skb() to fail. Propagate the error to the caller,
so it can clean up and drop the packet. The sender should end up retransmitting
the packet, hopefully at a time we're prepared to allocate skb's again.

Reported-By: Nicholas Krause <xerofoify@...il.com>
Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@...edu>

--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c	2014-09-05 15:51:00.005660044 -0400
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c	2014-09-08 17:42:16.773748142 -0400
@@ -847,6 +847,8 @@ static u8 parse_subframe(struct sk_buff
 #else
 			/* Allocate new skb for releasing to upper layer */
 			sub_skb = dev_alloc_skb(nSubframe_Length + 12);
+			if (!sub_skb)
+				return 0;
 			skb_reserve(sub_skb, 12);
 			data_ptr = (u8 *)skb_put(sub_skb, nSubframe_Length);
 			memcpy(data_ptr, skb->data, nSubframe_Length);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/