linux-kernel - [PATCH percpu/for-3.18] percpu: fix locking regression in the failure path of pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140908230734.GF3806@mtj.dyndns.org>
Date:	Tue, 9 Sep 2014 08:07:34 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	kbuild test robot <fengguang.wu@...el.com>, kbuild@...org,
	dan.carpenter@...cle.com, linux-kernel@...r.kernel.org
Subject: [PATCH percpu/for-3.18] percpu: fix locking regression in the
 failure path of pcpu_alloc()

>From 23cb8981ed929b4dd48141401cd0fd31e0fa4ed0 Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@...nel.org>
Date: Tue, 9 Sep 2014 08:02:45 +0900

While updating locking, b38d08f3181c ("percpu: restructure locking")
broke pcpu_create_chunk() creation path in pcpu_alloc().  It returns
without releasing pcpu_alloc_mutex.  Fix it.

Signed-off-by: Tejun Heo <tj@...nel.org>
Reported-by: Julia Lawall <julia.lawall@...6.fr>
---
Applied to percpu/for-3.18.

Thanks a lot!

 mm/percpu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/percpu.c b/mm/percpu.c
index 867efd3..af3dd27 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -974,6 +974,7 @@ restart:
 	if (list_empty(&pcpu_slot[pcpu_nr_slots - 1])) {
 		chunk = pcpu_create_chunk();
 		if (!chunk) {
+			mutex_unlock(&pcpu_alloc_mutex);
 			err = "failed to allocate new chunk";
 			goto fail;
 		}
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/