linux-kernel - Re: [PATCH 4/4] staging: lustre: Fix potential buffer underflow

Open Source and information security mailing list archives

Message-ID: <FB7D4E1C-31A3-4A86-9B3F-C00A59DCF339@intel.com>
Date:	Mon, 8 Sep 2014 23:31:41 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Hugues <morisset.hugues@...il.com>,
	"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>
Subject: Re: [PATCH 4/4] staging: lustre: Fix potential buffer underflow

Thanks!

Actually, I do't think this function is useful on the client.
>From the name of it, it would have been used in the server code, but even there it was recently removed as I now see.

I'll submit a removal patch.

On Sep 8, 2014, at 6:38 PM, Dan Carpenter wrote:

> On Tue, Sep 09, 2014 at 12:12:01AM +0200, Hugues wrote:
>> Fix potential buffer underflow
>> 
>> When the string 'name' start with a '-' ptr == name and so --ptr will
>> underflow, this patch corrected this by checking ptr before decrementing.
> 
> Good eye.  Please fix up the changelog and send it inline etc and
> resend.  I've added Oleg and Andreas to the CC list so that this doesn't
> get lost.
> 
> regards,
> dan carpenter
> 
>>> From 5786040323bd1dc3149fb4afbea9f01e2bf4cfdf Mon Sep 17 00:00:00 2001
>> From: Hugues Morisset <morisset.hugues@...il.com>
>> Date: Mon, 8 Sep 2014 22:59:04 +0200
>> Subject: [PATCH 4/4] staging: lustre: Fix potential buffer underflow
>> 
>> Signed-off-by: Hugues Morisset <morisset.hugues@...il.com>
>> ---
>> drivers/staging/lustre/lustre/include/obd.h | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/staging/lustre/lustre/include/obd.h b/drivers/staging/lustre/lustre/include/obd.h
>> index 409eae6..bb67e40 100644
>> --- a/drivers/staging/lustre/lustre/include/obd.h
>> +++ b/drivers/staging/lustre/lustre/include/obd.h
>> @@ -677,7 +677,12 @@ static inline int is_osp_on_mdt(char *name)
>> 	if (strncmp(ptr + 1, "MDT", 3) != 0)
>> 		return 0;
>> 
>> -	while (*(--ptr) != '-' && ptr != name);
>> +	if (ptr == name)
>> +		return 0;
>> +
>> +	--ptr;
>> +	while (ptr != '-' && ptr != name)
>> +		--ptr;
>> 
>> 	if (ptr == name)
>> 		return 0;
>> -- 
>> 2.1.0
>> 
> 
>> _______________________________________________
>> devel mailing list
>> devel@...uxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives