linux-kernel - Re: [PATCH 00/26] tty/serial flow control fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Sep 2014 16:43:24 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Jiri Slaby <jslaby@...e.cz>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/26] tty/serial flow control fixes

On Mon, Sep 08, 2014 at 07:33:51PM -0400, Peter Hurley wrote:
> On 09/08/2014 07:24 PM, Greg Kroah-Hartman wrote:
> > On Tue, Sep 02, 2014 at 05:39:09PM -0400, Peter Hurley wrote:
> >> Hi Greg,
> >>
> >> This patch series reworks the internals of tty and serial flow control to
> >> fix multiple races in both START/STOP flow control and RTS/CTS flow control.
> >>
> >> The main changes in this series are:
> >> Patch 1
> >>    Backs out the UPF_HARD_FLOW kludge for 8250. This revert should be
> >>    for mainline and -next
> >>
> >> Patches 3-7
> >>    Fixes to x_char handling (ie., sending START/STOP) both in the serial
> >>    core and to several UART drivers
> >>
> >> Patches 10-15
> >>    Rename and move ASYNC_CTS_FLOW and ASYNC_CHECK_CD statuses into
> >>    a private field for the serial core, and add helper functions to test
> >>    those statuses for UART drivers.
> >>
> >>    This is a necessary step toward making tty port->flags SMP-safe, without
> >>    introducing a new lock.
> > 
> > I stopped applying at patch 13, due to the objections to that patch.
> > Please redo the rest of the series and resend.
> 
> I'm going to wait for the fallout from patch 21 to shake out first.

Why, the earlier patches in this series should be ok to go, right?  They
don't depend on 21 to be "correct".

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/