linux-kernel - Re: [PATCH] drivers: media: radio: radio-miropcm20.c: include missing header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <540D63D1.2010402@xs4all.nl>
Date:	Mon, 08 Sep 2014 10:07:45 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>
CC:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jim Davis <jim.epost@...il.com>
Subject: Re: [PATCH] drivers: media: radio: radio-miropcm20.c: include missing
 header file

On 09/06/2014 01:24 PM, Sudip Mukherjee wrote:
> On Fri, Aug 29, 2014 at 01:38:01PM +0530, Sudip Mukherjee wrote:
>> with -Werror=implicit-function-declaration build failed with error :
>> error: implicit declaration of function 'inb'
>> error: implicit declaration of function 'outb'
>>
>> Reported-by: Jim Davis <jim.epost@...il.com>
>> Signed-off-by: Sudip Mukherjee <sudip@...torindi.org>
>> ---
>>
>> Jim reported for next-20140828 , but the error still persists in next-20140829 also.
>>
>>
>>  drivers/media/radio/radio-miropcm20.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm20.c
>> index 998919e..3309f7c 100644
>> --- a/drivers/media/radio/radio-miropcm20.c
>> +++ b/drivers/media/radio/radio-miropcm20.c
>> @@ -36,6 +36,7 @@
>>  #include <media/v4l2-fh.h>
>>  #include <media/v4l2-event.h>
>>  #include <sound/aci.h>
>> +#include<linux/io.h>
>>  
>>  #define RDS_DATASHIFT          2   /* Bit 2 */
>>  #define RDS_DATAMASK        (1 << RDS_DATASHIFT)
>> -- 
>> 1.8.1.2
>>
> 
> gentle ping.
> build fails on next-20140905 also with the attached config (-Werror=implicit-function-declaration)

I hadn't forgotten this. However, I will be taking the same patch from Randy Dunlap
instead of yours since his commit log was formatted better, so less work for me :-)

Regards,

	Hans

> 
> thanks
> sudip
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/