linux-kernel - Re: question about two ASoC commits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2014 11:19:54 +0100
From:	Mark Brown <broonie@...nel.org>
To:	jiwang <jiada_wang@...tor.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	"Frkuska, Joshua" <Joshua_Frkuska@...tor.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: question about two ASoC commits

On Tue, Sep 09, 2014 at 05:36:36PM +0900, jiwang wrote:

> Can anyone tell me what is the reasoning of the following two commits
> commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings
> commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings

> with these two commits, now we have
> #define SND_SOC_DAIFMT_GATED            (0 << 4)
> #define SND_SOC_DAIFMT_NB_NF            (0 << 8)
> in soc-dai.h
> what's the good to shift 0 with different numbers?
> no matter the number, they both equal to 0.

> IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT)
> should have different value, isn't it?

As the commit message says this is so that we have a default value which
does something sensible.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)