linux-kernel - Re: [PATCH v2] pinctrl: st: remove gpiochip in failure cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Sep 2014 12:27:22 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kernel@...inux.com
CC:	Srinivas Kandagatla <srinivas.kandagatla@...il.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.com>,
	Maxime Coquelin <maxime.coquelin@...com>,
	Patrice Chotard <patrice.chotard@...com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bjorn Andersson <bjorn.andersson@...ymobile.com>
Subject: Re: [PATCH v2] pinctrl: st: remove gpiochip in failure cases


Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>


On 09/09/14 08:51, Pramod Gurav wrote:
> This patch releases gpiochip related resources by calling
> gpiochip_remove when gpiochip_irqchip_add fails.
>
> CC: Srinivas Kandagatla <srinivas.kandagatla@...il.com>
> CC: Srinivas Kandagatla <srinivas.kandagatla@...aro.com>
> CC: Maxime Coquelin <maxime.coquelin@...com>
> CC: Patrice Chotard <patrice.chotard@...com>
> CC: Linus Walleij <linus.walleij@...aro.org>
> CC: Bjorn Andersson <bjorn.andersson@...ymobile.com>
>
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
> ---
> Changes since v1:
> Dropped adding remove function as it will never be tested as
> the driver is bool.
>
>   drivers/pinctrl/pinctrl-st.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 5475374..af2f589 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1517,6 +1517,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
>   					   0, handle_simple_irq,
>   					   IRQ_TYPE_LEVEL_LOW);
>   		if (err) {
> +			gpiochip_remove(&bank->gpio_chip);
>   			dev_info(dev, "could not add irqchip\n");
>   			return err;
>   		}
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/