[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 8 Sep 2014 17:06:28 -0700
From: Darren Hart <dvhart@...radead.org>
To: Frans Klaver <fransklaver@...il.com>
Cc: Corentin Chary <corentin.chary@...il.com>,
Matthew Garrett <matthew.garrett@...ula.com>,
acpi4asus-user@...ts.sourceforge.net,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeepc-laptop: remove possible use of uninitialized value
On Thu, Sep 04, 2014 at 12:53:25AM +0200, Frans Klaver wrote:
> In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call
> fails, 'value' remains possibly uninitialized. In that case 'value'
> shouldn't be used to produce the store_sys_acpi()s return value.
>
> Only test the return value of set_acpi() if we can actually call it.
> Return rv otherwise.
>
> Signed-off-by: Frans Klaver <fransklaver@...il.com>
FYI, based on recent discussion with Paul, Greg, and Frans, I am not picking
this up, but waiting for a next rev from Frans, possibly including Paul's
original patch.
--
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists