linux-kernel - Re: KVM: x86: handle idiv overflow at kvm_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 09 Sep 2014 15:34:26 +0200
From:	Philipp Hahn <hahn@...vention.de>
To:	Marcelo Tosatti <mtosatti@...hat.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: KVM: x86: handle idiv overflow at kvm_write_tsc for stable-3.10

Hello Marcelo,

On 03.09.2014 20:42, Marcelo Tosatti wrote:
> On Wed, Sep 03, 2014 at 10:16:40AM +0200, Philipp Hahn wrote:
>> can we please 8915aa27d5efbb9185357175b0acf884325565f9 get applied to
>> 3.10 too?
>>
>>> commit 8915aa27d5efbb9185357175b0acf884325565f9
>>> Author: Marcelo Tosatti <mtosatti@...hat.com>
>>> Date:   Tue Jun 11 23:31:12 2013 -0300
>>>
>>>     KVM: x86: handle idiv overflow at kvm_write_tsc
>>>
>>>     Its possible that idivl overflows (due to large delta stored in
>> usdiff,
>>>     valid scenario).
>>>
>>>     Create an exception handler to catch the overflow exception
>> (division by zero
>>>     is protected by vcpu->arch.virtual_tsc_khz check), and interpret
>> it accordingly
>>>     (delta is larger than USEC_PER_SEC).
>>>
>>>     Fixes https://bugzilla.redhat.com/show_bug.cgi?id=969644
>>>
>>>     Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>
>>>     Signed-off-by: Gleb Natapov <gleb@...hat.com>
...
>> Tested-by: Philipp Hahn <hahn@...vention.de>
...
> Yes, can you send the patch accordingly to the stable guidelines please?

Maybe I'm to stupid right now, but I find
linux/Documentation/stable_kernel_rules.txt unclear on what I'm supposed
to do:

1. cherry-pick the patch myself?
2. amend the commit message by adding the original commit it
3. where should the name of the stable branch go?
4. amend the commit message by adding myself as a tester? Or do I need
to sign it off?
5. send that patch to <mailto:stable@...r.kernel.org>.

It did seem to have worked, as I never received an acknowledgement nor
is it listed in
<http://git.kernel.org/cgit/linux/kernel/git/stable/stable-queue.git>.
Maybe you can do it and cc: me so I can do it right next time myself.

Thanks.

Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/