lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Sep 2014 17:47:53 +0200 From: Arnd Bergmann <arnd@...db.de> To: Alban Bedel <alban.bedel@...onic-design.de> Cc: Thierry Reding <thierry.reding@...il.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-pwm@...r.kernel.org, Grant Likely <grant.likely@...aro.org>, Kumar Gala <galak@...eaurora.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Mark Rutland <mark.rutland@....com>, Pawel Moll <pawel.moll@....com>, Rob Herring <robh+dt@...nel.org>, Roland Stigge <stigge@...com.de> Subject: Re: [PATCH V3] pwm: lpc32xx - Add a driver for the motor PWM On Tuesday 09 September 2014 17:42:41 Alban Bedel wrote: > +config PWM_LPC32XX_MOTOR > + tristate "LPC32xx Motor PWM support" > + depends on ARCH_LPC32XX > + help > + Generic PWM framework driver for LPC32xx motor PWM. The LPC32xx SOC > + has one motor PWM controllers. > + > + To compile this driver as a module, choose M here: the module > + will be called pwm-lpc32xx-motor. > + Can you change the dependency to ARCH_LPC32XX || COMPILE_TEST and add explicit dependencies for the subsystems the driver depends on (pwm and clk, I guess)? That would give us better build-time coverage with allmodconfig. > + /* Write to limit register -> period */ > + __raw_writel(period, lpc32xx->base + MCLIM_REG_OFFSET(pwm)); > + > + /* Write to match register -> duty */ > + __raw_writel(period - duty, lpc32xx->base + MCMAT_REG_OFFSET(pwm)); Please don't use __raw_{writel,readl} in driver, and change that to use readl_relaxed()/writel_relaxed(). Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists