lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Sep 2014 13:32:40 -0500 From: Shirish Pargaonkar <shirishpargaonkar@...il.com> To: Alan Stern <stern@...land.harvard.edu> Cc: Tejun Heo <tj@...nel.org>, James Bottomley <James.Bottomley@...senpartnership.com>, Jens Axboe <axboe@...nel.dk>, SCSI development list <linux-scsi@...r.kernel.org>, Kernel development list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Block: fix unbalanced bypass-disable in blk_register_queue Tested-by: Shirish Pargaonkar <shirishpargaonkar@...il.com> On Tue, Sep 9, 2014 at 10:50 AM, Alan Stern <stern@...land.harvard.edu> wrote: > When a queue is registered, the block layer turns off the bypass > setting (because bypass is enabled when the queue is created). This > doesn't work well for queues that are unregistered and then registered > again; we get a WARNING because of the unbalanced calls to > blk_queue_bypass_end(). > > This patch fixes the problem by making blk_register_queue() call > blk_queue_bypass_end() only the first time the queue is registered. > > Signed-off-by: Alan Stern <stern@...land.harvard.edu> > CC: Tejun Heo <tj@...nel.org> > CC: James Bottomley <James.Bottomley@...senPartnership.com> > CC: Jens Axboe <axboe@...nel.dk> > > --- > > [as1765] > > > block/blk-sysfs.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > Index: usb-3.17/block/blk-sysfs.c > =================================================================== > --- usb-3.17.orig/block/blk-sysfs.c > +++ usb-3.17/block/blk-sysfs.c > @@ -554,8 +554,10 @@ int blk_register_queue(struct gendisk *d > * Initialization must be complete by now. Finish the initial > * bypass from queue allocation. > */ > - queue_flag_set_unlocked(QUEUE_FLAG_INIT_DONE, q); > - blk_queue_bypass_end(q); > + if (!blk_queue_init_done(q)) { > + queue_flag_set_unlocked(QUEUE_FLAG_INIT_DONE, q); > + blk_queue_bypass_end(q); > + } > > ret = blk_trace_init_sysfs(dev); > if (ret) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists