linux-kernel - Re: [PATCH] Staging: octeon-hcd: removed dummy label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2014 22:02:00 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nitin Kuppelur <nitinkuppelur@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: octeon-hcd: removed dummy label

On Tue, Sep 09, 2014 at 05:22:19PM +0200, Nitin Kuppelur wrote:
> This is a patch to the octeon-hcd.c file that
> removes dummy label i.e. label followed by return of
> void function
> 
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@...il.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index 8a80982..5fffef2 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2253,9 +2253,8 @@ static void __cvmx_usb_perform_complete(
>  			/* Increment to the next location in our packet array */
>  			transaction->iso_packets++;
>  			transaction->stage = CVMX_USB_STAGE_NON_CONTROL;
> -			goto done;
> +			return;
>  		}
> -	}
>  

Wat?  Does this still compile without the curly brace?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/