lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Sep 2014 12:17:36 -0700 From: Greg KH <greg@...ah.com> To: Markos Chandras <markos.chandras@...tec.com> Cc: linux-mips@...ux-mips.org, Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: > Commit e676253b19b2d269cccf67fdb1592120a0cd0676 > (serial/8250: Add support for RS485 IOCTLs) added cases for the > TIOC{S,G}RS485 commands but this broke the build for MIPS: > > drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl': > drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared > (first use in this function) > drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared > (first use in this function) > > This patch adds these missing definitions > > Cc: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com> > Cc: <linux-next@...r.kernel.org> > Cc: <linux-kernel@...r.kernel.org> > Cc: <linux-serial@...r.kernel.org> > Signed-off-by: Markos Chandras <markos.chandras@...tec.com> > --- > arch/mips/include/uapi/asm/ioctls.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h > index b1e637757fe3..34050cb6b631 100644 > --- a/arch/mips/include/uapi/asm/ioctls.h > +++ b/arch/mips/include/uapi/asm/ioctls.h > @@ -76,6 +76,8 @@ > > #define TIOCSBRK 0x5427 /* BSD compatibility */ > #define TIOCCBRK 0x5428 /* BSD compatibility */ > +#define TIOCGRS485 0x542E > +#define TIOCSRS485 0x542F Any reason you aren't using the _IOR() type macros here? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists