[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 9 Sep 2014 14:55:38 -0700
From: Todd Poynor <toddpoynor@...gle.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Zoran Markovic <zrn.markovic@...il.com>,
Anton Vorontsov <anton@...msg.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
David Woodhouse <dwmw2@...radead.org>,
Arve Hjonnevag <arve@...roid.com>,
John Stultz <john.stultz@...aro.org>
Subject: Re: [RFC PATCH] pm: prevent suspend until power supply events are processed
On Wed, Sep 3, 2014 at 9:53 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 4 September 2014 10:21, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>>>> >> + /* dependent power supplies (e.g. battery) may have changed
>>>> >> + * state as a result of this event, so poll again and hold
>>>> >> + * the wakeup_source until all events are processed.
>>>> >> + */
>
> But isn't this comment still incorrect? Its not about dependent supplies
> but the race between the work-handler and its enqueuing?
I believe you are correct: the code is to make sure we do not relax a
wakeup source that has had multiple events queued, until all are
notified to userspace.
Todd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists