linux-kernel - Re: [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on i.mx6dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140910051615.GA29006@Robin-OptiPlex-780>
Date:	Wed, 10 Sep 2014 13:16:16 +0800
From:	Robin Gong <b38343@...escale.com>
To:	Shawn Guo <shawn.guo@...escale.com>
CC:	<kernel@...gutronix.de>, <robh+dt@...nel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<linux@....linux.org.uk>, <linux-arm-kernel@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<Frank.Li@...escale.com>
Subject: Re: [PATCH v1] ARM: dts: imx6dl: disable dma support for spi on
 i.mx6dl

On Wed, Sep 10, 2014 at 11:21:30AM +0800, Shawn Guo wrote:
> On Wed, Sep 10, 2014 at 09:33:36AM +0800, Robin Gong wrote:
> > There is one weird data in rxfifo after one full rx/tx transfer
> > done sometimes. It looks a design issue and hard to workaround
> > totally, so disable dma functhion here. And will re-enable it
> > once the root cause found.
> > 
> > Signed-off-by: Robin Gong <b38343@...escale.com>
> > ---
> >  arch/arm/boot/dts/imx6dl.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi
> > index b453e0e..e84a1ff 100644
> > --- a/arch/arm/boot/dts/imx6dl.dtsi
> > +++ b/arch/arm/boot/dts/imx6dl.dtsi
> > @@ -102,6 +102,22 @@
> >  	};
> >  };
> >  
> > +&ecspi1 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi2 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi3 {
> > +	dma-names = "", "";
> > +};
> > +
> > +&ecspi4 {
> > +	dma-names = "", "";
> > +};
> > +
> 
> This looks odd.  Can we drop the dma properties from imx6qdl.dtsi,
> and only add them in imx6q.dtsi instead?
> 
> Shawn
>
Ok, I'll send v2.
> >  &hdmi {
> >  	compatible = "fsl,imx6dl-hdmi";
> >  };
> > -- 
> > 1.9.1
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/