linux-kernel - Re: [PATCH] checkpatch: struct of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140910072935.GA3755@pengutronix.de>
Date:	Wed, 10 Sep 2014 09:29:35 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de, Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH] checkpatch: struct of_device_id should usually be const

On Wed, Sep 10, 2014 at 12:23:17AM -0700, Joe Perches wrote:
> On Wed, 2014-09-10 at 09:15 +0200, Uwe Kleine-König wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -4941,6 +4941,7 @@ sub process {
> >  				mtrr_ops|
> >  				neigh_ops|
> >  				nlmsvc_binding|
> > +				of_device_id|
> >  				pci_raw_ops|
> >  				pipe_buf_operations|
> >  				platform_hibernation_ops|
> 
> Fine by me, there are ~1200 or so const uses.
> 
> There are also ~350 of these that are not const.
> 
> Are most all of those supposed to be const?
Yeah, I'm working on a patch series to fix most of these. I thought I
sent out the checkpatch patch first to slow down the occurences to fix.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/