linux-kernel - Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3814561.AbrslYBNjb@wuerfel>
Date:	Wed, 10 Sep 2014 10:22:36 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Murali Karicheri <m-karicheri2@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	bhelgaas@...gle.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: keystone: update to support multiple pci ports

On Tuesday 09 September 2014 18:50:13 Murali Karicheri wrote:
> My mistake. It is the device ID, not vendor ID. The PCI driver supports 
> PCI h/w on K2HK, K2E and K2L SoCs for which PCI device IDs are assigned as
> 
> +#define PCIE_RC_K2HK           0xb008
> +#define PCIE_RC_K2E            0xb009
> +#define PCIE_RC_K2L            0xb00a
> +
> 
> and the same driver code runs on all these h/w. The device ID is not 
> filled in by default by the h/w, in the config space of the RC at offset 
> 1000h "VENDOR_DEVICE_ID Vendor and Device Identification Register". 
> Same is available in a seperate SoC register whose offset is specified 
> by index 2. This is read by driver and updated in the config space. The 
> Vendor ID is however set by default.
> 
> There is a mrrs PCI quirk required for Keystone PCI which depends on 
> this vendor ID to be filled correctly as it match vendor id/ device id 
> of the bridge device to apply the quirk.
> 
> Hope this clarify your question.

Ok, I understand now. Yes, this makes sense, though I wonder if it would
have been easier to handle the quirk in a different way based on the
driver rather than the PCI ID. It's probably not worth revisiting though,
unless Bjorn wants to see it done differently now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/