linux-kernel - Re: [PATCH] fs: seq_file: optimize seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140910132123.GZ7996@ZenIV.linux.org.uk>
Date:	Wed, 10 Sep 2014 14:21:23 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Dmitry Voytik <voytikd@...il.com>
Cc:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs: seq_file: optimize seq_pad()

On Wed, Sep 10, 2014 at 01:20:19PM +0400, Dmitry Voytik wrote:
> Use seq_putc() instead of seq_printf() in seq_pad() because the
> former is faster.

_Solitary_ seq_putc() is certainly going to be faster, but that loop...
Do you have profiling results, or is it just an apriori "printf must
be sloooowwww"?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/