linux-kernel - Re: [PATCH] tty: serial: serial_mctrl_gpio: Fix build error for !GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140910135716.GA23074@kroah.com>
Date:	Wed, 10 Sep 2014 06:57:16 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Tobias Klauser <tklauser@...tanz.ch>,
	Alexander Shiyan <shc_work@...l.ru>
Cc:	Jim Davis <jim.epost@...il.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, jslaby@...e.cz,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: serial: serial_mctrl_gpio: Fix build error for
 !GPIOLIB

On Wed, Sep 10, 2014 at 10:06:58AM +0200, Tobias Klauser wrote:
> If SERIAL_MCTRL_GPIO is selected but GPIOLIB is not, the noop functions
> from serial_mctrl_gpio.h are pulled in. However, serial_mctrl_gpio.c is
> still compiled, leading to function redefinition build errors. Since all
> drivers that include serial_mctrl_gpio.h also depend on
> SERIAL_MCTRL_GPIO, let it depend on GPIOLIB as well remove the noop
> functions alltogether.
> 
> Reported-by: Jim Davis <jim.epost@...il.com>
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> ---
>  drivers/tty/serial/Kconfig             |  1 +
>  drivers/tty/serial/serial_mctrl_gpio.h | 35 ----------------------------------
>  2 files changed, 1 insertion(+), 35 deletions(-)

I fixed this yesterday with commit below from Alexander, which does
things a bit differently than you.  Any objections to it?

thanks,

greg k-h

View attachment "0004-serial-clps711x-Fix-COMPILE_TEST-build-for-target-wi.patch" of type "text/x-diff" (1530 bytes)