linux-kernel - Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410358807.24028.44.camel@joe-AO725>
Date:	Wed, 10 Sep 2014 07:20:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ilya Dryomov <ilya.dryomov@...tank.com>
Cc:	netdev@...r.kernel.org, Sage Weil <sage@...tank.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ceph Development <ceph-devel@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 2/5] ceph: Convert pr_warning to pr_warn

On Wed, 2014-09-10 at 16:38 +0400, Ilya Dryomov wrote:
> On Wed, Sep 10, 2014 at 8:17 AM, Joe Perches <joe@...ches.com> wrote:
> > Use the more common pr_warn.
> >
> > Other miscellanea:
> >
> > o Coalesce formats
> > o Realign arguments
[]
> > diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c
[]
> > @@ -2828,8 +2828,9 @@ static void con_work(struct work_struct *work)
> >   */
> >  static void con_fault(struct ceph_connection *con)
> >  {
> > -       pr_warning("%s%lld %s %s\n", ENTITY_NAME(con->peer_name),
> > -              ceph_pr_addr(&con->peer_addr.in_addr), con->error_msg);
> > +       pr_warn("%s%lld %s %s\n",
> > +               ENTITY_NAME(con->peer_name),
> > +               ceph_pr_addr(&con->peer_addr.in_addr), con->error_msg);
> 
> Just wondering, why did you move ENITITY_NAME argument to the next
> line?  I see you are doing this pretty consistently.  Is this a style
> guideline or something?

Hello Ilya.

It's just a personal preference to have the
formats on one line and its arguments on
another when the format and its arguments
don't fit 80 columns.

Maximal 80 column fill isn't always easy for me
to read.

I find it easier to match formats and arguments
when scanning because my eye doesn't have to
scan to the end of the format line.

If you don't like it, it's your code.  Change it.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/