linux-kernel - Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140908093051.GA12657@localhost>
Date:	Mon, 8 Sep 2014 02:30:51 -0700
From:	Olof Johansson <olof@...om.net>
To:	behanw@...verseincode.com
Cc:	anderson@...hat.com, catalin.marinas@....com, cl@...ux.com,
	cov@...eaurora.org, jays.lee@...sung.com, msalter@...hat.com,
	sandeepa.prabhu@...aro.org, srivatsa.bhat@...ux.vnet.ibm.com,
	steve.capper@...aro.org, sudeep.karkadanagesha@....com,
	takahiro.akashi@...aro.org, Vijaya.Kumar@...iumnetworks.com,
	will.deacon@....com, a.p.zijlstra@...llo.nl, acme@...nel.org,
	akpm@...ux-foundation.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, lorenzo.pieralisi@....com,
	marc.zyngier@....com, Matthew.Leach@....com, mingo@...hat.com,
	paulus@...ba.org, Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with
 clang

On Fri, Sep 05, 2014 at 04:24:20PM -0700, behanw@...verseincode.com wrote:
> From: Mark Charlebois <charlebm@...il.com>
> 
> Fix variable types for 64-bit inline assembly.
> 
> This patch now works with both gcc and clang.
> 
> Signed-off-by: Mark Charlebois <charlebm@...il.com>
> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> ---
>  arch/arm64/include/asm/arch_timer.h | 26 +++++++++++++++-----------
>  arch/arm64/include/asm/uaccess.h    |  2 +-
>  arch/arm64/kernel/debug-monitors.c  |  8 ++++----
>  arch/arm64/kernel/perf_event.c      | 34 +++++++++++++++++-----------------
>  arch/arm64/mm/mmu.c                 |  2 +-
>  5 files changed, 38 insertions(+), 34 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h
> index 9400596..c1f87e0 100644
> --- a/arch/arm64/include/asm/arch_timer.h
> +++ b/arch/arm64/include/asm/arch_timer.h
> @@ -37,19 +37,23 @@ void arch_timer_reg_write_cp15(int access, enum arch_timer_reg reg, u32 val)
>  	if (access == ARCH_TIMER_PHYS_ACCESS) {
>  		switch (reg) {
>  		case ARCH_TIMER_REG_CTRL:
> -			asm volatile("msr cntp_ctl_el0,  %0" : : "r" (val));
> +			asm volatile("msr cntp_ctl_el0,  %0"
> +				: : "r" ((u64)val));

Ick. Care to elaborate in the patch description why this is needed with
LLVM? It's really messy and very annoying having to cast register values
every time they're passed in, instead of the compiler handling it for you.

Is there a way to catch this with GCC? If not, I expect you to get broken
all the time on this by people who don't notice.



-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/