linux-kernel - Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Sep 2014 20:20:53 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Jeff Layton <jlayton@...marydata.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [RFC PATCH 08/12] nfs: convert lock handling to use
 file_lock_context

On Wed, Sep 10, 2014 at 03:17:34PM -0400, J. Bruce Fields wrote:
> On Wed, Sep 10, 2014 at 10:28:46AM -0400, Jeff Layton wrote:
> > Signed-off-by: Jeff Layton <jlayton@...marydata.com>
> > ---
> >  fs/nfs/delegation.c | 37 +++++++++++++++++++++----------------
> >  fs/nfs/nfs4state.c  | 24 +++++++++++++++---------
> >  fs/nfs/pagelist.c   |  3 ++-
> >  fs/nfs/write.c      | 39 +++++++++++++++++++++++++++++++++------
> >  4 files changed, 71 insertions(+), 32 deletions(-)
> > 
> > diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
> > index 5853f53db732..22c6eed9bb5b 100644
> > --- a/fs/nfs/delegation.c
> > +++ b/fs/nfs/delegation.c
> > @@ -85,25 +85,30 @@ static int nfs_delegation_claim_locks(struct nfs_open_context *ctx, struct nfs4_
> >  {
> >  	struct inode *inode = state->inode;
> >  	struct file_lock *fl;
> > +	struct file_lock_context *flctx = inode->i_flctx;

Ummm...  Something ought to be done for inflicting identifiers like that on
those who'll read that code.  But That Would Probably Be Illegal(tm), more's
the pity...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/