linux-kernel - Re: repeated bugs in new rtl wifi drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJmyyWrsS2EFPT59RjK-np3sqmxe69meecmpicv6BNKrA@mail.gmail.com>
Date:	Thu, 11 Sep 2014 16:50:41 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	"John W. Linville" <linville@...driver.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: repeated bugs in new rtl wifi drivers

On Thu, Sep 11, 2014 at 4:38 PM, Larry Finger <Larry.Finger@...inger.net> wrote:
> On 09/11/2014 05:27 PM, Kees Cook wrote:
>>
>> Hi,
>>
>> I keep fixing this same bug that keeps showing up in the rtl wifi
>> drivers. CL_PRINTF keeps getting redefined (incorrectly) instead of
>> using a correctly fixed global. Is there a way to stop this from
>> happening again?
>>
>> Here are the past three (identical) fixes I've landed:
>> a3355a62673e2c4bd8617d2f07c8edee92a89b8d
>> 037526f1ae7eeff5cf27ad790ebfe30303eeebe8
>> 6437f51ec36af8ef1e3e2659439b35c37e5498e2
>>
>> And the buildbot report below seems to show there are more to be made. :)
>
>
> Sorry that I missed your fix. I should have seen it come through Linville's
> list. I will push your fix through again.

Well, I should clarify: it's not getting unfixed/reverted, but rather,
it hasn't been consolidated to avoid needing the code again in the
future. All three of the fixes above are on almost identical header
files. If we could consolidate them, that would be great, and it would
keep things much nicer.

>
> We are in the process of unifying the in-house driver development at Realtek
> with what I have been doing in the kernel. Unfortunately, this will involve
> rather massive changes in all the codes. I am trying not to wipe out fixes
> such as this one, but I expect that others will slip through. Once this
> painful process is completed, maintaining the drivers should be a lot
> easier.

Good to hear! :) Thanks for working on this!

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/