linux-kernel - Re: [PATCH V4] pwm: lpc32xx - Add a driver for the motor PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140911103621.198f7ef6@avionic-0020>
Date:	Thu, 11 Sep 2014 10:36:21 +0200
From:	Alban Bedel <alban.bedel@...onic-design.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Alban Bedel <alban.bedel@...onic-design.de>,
	Thierry Reding <thierry.reding@...il.com>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pwm@...r.kernel.org, Grant Likely <grant.likely@...aro.org>,
	Kumar Gala <galak@...eaurora.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Mark Rutland <mark.rutland@....com>,
	Pawel Moll <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Roland Stigge <stigge@...com.de>
Subject: Re: [PATCH V4] pwm: lpc32xx - Add a driver for the motor PWM

On Wed, 10 Sep 2014 18:28:39 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> On Wednesday 10 September 2014 17:59:41 Alban Bedel wrote:
> > On Wed, 10 Sep 2014 17:51:36 +0200
> > Arnd Bergmann <arnd@...db.de> wrote:
> > 
> > > On Wednesday 10 September 2014 17:43:42 Alban Bedel wrote:
> > > > +- #pwm-cells: should be 3. See pwm.txt in this directory for a description of
> > > > +  the cells format. The only third cell flag supported by this binding is
> > > > +  PWM_POLARITY_INVERTED.
> > > 
> > > If you don't have multiple pwm outputs or programmable period, I would say it
> > > should use #pwm-cells=<1> and only pass the polarity.
> > 
> > There is 3 channel, so 3 PWM from the API POV, and the period is
> > independently programmable for each one.
> 
> Then you should put the channel number into the first cell and the period
> length into the second cell, as the pwm.txt document says.

That's what is implemented in this patch, by using
of_pwm_xlate_with_flags() for the .of_xlate callback.

Alban

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)