linux-kernel - Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140911113548.GB5149@katana>
Date:	Thu, 11 Sep 2014 13:35:48 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Nick Dyer <nick.dyer@...ev.co.uk>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Lee Jones <lee.jones@...aro.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	"Bowens, Alan" <Alan.Bowens@...el.com>
Subject: Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table


> > This is a workaround. It would make sense, however, to add it because we
> > want to support i2c_board_info structures.
> > 
> 
> I think it really depends if an IP block can be used on non-DT platforms
> (which I think is true for this trackpad) but if a driver is for an IP block
> that can only be used on a DT-only platform (e.g: a PMIC that is controlled
> over I2C and is only compatible with a DT-only SoC) then I don't think we need
> to support the i2c_board_info structure and can get rid of the I2C ID table on
> these drivers once Lee series land.

That is exactly what I meant. It should be only added if there is a
reason other than "workaround". If you say, it doesn't make sense on
non-DT, then it should not be added.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)