linux-kernel - Re: [RESEND][PATCH] userns: use marco instead of magic number for max userns level

Open Source and information security mailing list archives

Message-ID: <20140911163048.GF24386@ubuntumail>
Date:	Thu, 11 Sep 2014 16:30:48 +0000
From:	Serge Hallyn <serge.hallyn@...ntu.com>
To:	Chen Hanxiao <chenhanxiao@...fujitsu.com>
Cc:	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, Fabian Frederick <fabf@...net.be>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: [RESEND][PATCH] userns: use marco instead of magic number for
 max userns level

Quoting Chen Hanxiao (chenhanxiao@...fujitsu.com):
> Use marco instead of magic number
> for max user namespace level.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao@...fujitsu.com>

Acked-by: Serge E. Hallyn <serge.hallyn@...ntu.com>

> ---
>  kernel/user_namespace.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
> index aa312b0..5435489 100644
> --- a/kernel/user_namespace.c
> +++ b/kernel/user_namespace.c
> @@ -47,6 +47,8 @@ static void set_cred_user_ns(struct cred *cred, struct user_namespace *user_ns)
>  	cred->user_ns = user_ns;
>  }
>  
> +#define MAX_USER_NS_LEVEL 32
> +
>  /*
>   * Create a new user namespace, deriving the creator from the user in the
>   * passed credentials, and replacing that user with the new root user for the
> @@ -62,7 +64,7 @@ int create_user_ns(struct cred *new)
>  	kgid_t group = new->egid;
>  	int ret;
>  
> -	if (parent_ns->level > 32)
> +	if (parent_ns->level > MAX_USER_NS_LEVEL)
>  		return -EUSERS;
>  
>  	/*
> -- 
> 1.9.0
> 
> _______________________________________________
> Containers mailing list
> Containers@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/containers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives