linux-kernel - Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1410454368.8852.13.camel@AMDC723>
Date:	Thu, 11 Sep 2014 18:52:48 +0200
From:	Maciej Matraszek <m.matraszek@...sung.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] PM / Domains: add debugfs listing of struct
 generic_pm_domain-s

Hi Al!

On śro, 2014-09-10 at 20:18 +0100, Al Viro wrote:
> On Wed, Sep 10, 2014 at 01:28:56PM +0200, Maciej Matraszek wrote:
> 
> > +static int pm_genpd_summary_open(struct inode *inode, struct file *file)
> > +{
> > +	return single_open(file, pm_genpd_summary_show, inode->i_private);
> 							^^^^^^^^^^^^^^^^
> 							what for?
> 
> Where in pm_genpd_summary_show() are you using ->private?

Nowhere, thanks! (Just a mindless copy-paste from clk_summary_open().)

Regards,
-- 
Maciej Matraszek
Samsung R&D Institute Poland
Samsung Electronics


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/