linux-kernel - Re: [PATCH v5] ASoC: dapm: add code to configure dai link parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Sep 2014 19:37:22 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nikesh Oswal <nikesh@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v5] ASoC: dapm: add code to configure dai link parameters

On Thu, Sep 11, 2014 at 11:42:18AM +0100, Nikesh Oswal wrote:

> +	/* add kcontrol */
> +	for (i = 0; i < w->num_kcontrols; i++) {
> +		kcontrol = snd_soc_cnew(&w->kcontrol_news[i], w,
> +		w->name, NULL);
> +		ret = snd_ctl_add(card, kcontrol);

*sigh*  As I wrote before in response to exactly the same code:

| Throughout this you've got coding style problems, you're not indenting
| the continuations of multi-line statements.  Please try to follow the
| kernel coding style, if your code is visibly different to the rest of
| the codebase that's not good.

Please pay attention to review comments, just completely ignoring them
isn't good.  If you don't feel some change should be made then reply and
discuss.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)