linux-kernel - Re: [PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc) bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410461351.9942.19.camel@joe-AO725>
Date:	Thu, 11 Sep 2014 11:49:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	"J. German Rivera" <German.Rivera@...escale.com>
Cc:	gregkh@...uxfoundation.org, arnd@...db.de,
	linux-kernel@...r.kernel.org, stuart.yoder@...escale.com,
	Kim.Phillips@...escale.com, scottwood@...escale.com, agraf@...e.de,
	linuxppc-release@...ux.freescale.net
Subject: Re: [PATCH 2/4] drivers/bus: Freescale Management Complex (fsl-mc)
 bus driver

On Thu, 2014-09-11 at 12:34 -0500, J. German Rivera wrote:
> From: "J. German Rivera" <German.Rivera@...escale.com>
> 
> Platform device driver that sets up the basic bus infrastructure
> for the fsl-mc bus type, including support for adding/removing
> fsl-mc devices, register/unregister of fsl-mc drivers, and bus
> match support to bind devices to drivers.

[]

> diff --git a/drivers/bus/fsl-mc/fsl_mc_bus.c b/drivers/bus/fsl-mc/fsl_mc_bus.c
[]
> +/**
> + * fsl_mc_bus_match - device to driver matching callback
> + * @dev: the MC object device structure to match against
> + * @drv: the device driver to search for matching MC object device id
> + * structures
> + *
> + * Returns 1 on success, 0 otherwise.
> + */
> +static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv)
> +{
> +	const struct fsl_mc_device_match_id *id;
> +	struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
> +	struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(drv);
> +	bool found = false;
[]
> +out:
> +	pr_debug("%s: %s %s\n", __func__, dev_name(dev),
> +		 found ? "matched" : "not matched");

Thia should probably use dev_dbg

	dev_dbg(dev, "%smatched\n", found ? "" : "not ");

and let the dynamic debug mechanism emit the
function name if desired.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/