linux-kernel - Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140912134911.GA30816@xps8300>
Date:	Fri, 12 Sep 2014 16:49:11 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...com>,
	Vivek Gautam <gautam.vivek@...sung.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci

On Thu, Sep 11, 2014 at 08:31:19PM +0530, Kishon Vijay Abraham I wrote:
> > @@ -60,22 +59,33 @@ int dwc3_host_init(struct dwc3 *dwc)
> >  		goto err1;
> >  	}
> >  
> > +	phy_create_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > +			  dev_name(&xhci->dev));
> > +	phy_create_lookup(dwc->usb3_generic_phy, "usb3-phy",
> > +			  dev_name(&xhci->dev));
> > +
> 
> I don't think create lookup should be in host init. If it's dt boot, the
> binding should be in dt data or for other boot modes the bindig should be done
> in the board file. This just seems hacky to me.

So are you now suggesting that instead of using platform independent
solution of sharing the PHYs here, you would have us add platform
specific quirks? That would be totally wrong!

And please don't even consider use of board files especially if there
is an option. They are the one thing that we are meant to avoid if
possible! No?


Cheers,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/