linux-kernel - Re: [PATCH v2 9/9] blk-mq: support per-distpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54130F2A.7060508@kernel.dk>
Date:	Fri, 12 Sep 2014 09:20:10 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <ming.lei@...onical.com>, linux-kernel@...r.kernel.org
CC:	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2 9/9] blk-mq: support per-distpatch_queue flush machinery

On 2014-09-12 08:47, Ming Lei wrote:
> @@ -31,7 +33,15 @@ extern struct ida blk_queue_ida;
>   static inline struct blk_flush_queue *blk_get_flush_queue(
>   		struct request_queue *q, struct blk_mq_ctx *ctx)
>   {
> -	return q->fq;
> +	struct blk_mq_hw_ctx *hctx;
> +
> +	if (!q->mq_ops)
> +		return q->fq;
> +
> +	WARN_ON(!ctx);
> +	hctx = q->mq_ops->map_queue(q, ctx->cpu);
> +
> +	return hctx->fq;

Kill the WARN_ON(), we'll know soon enough of this happens anyway.


-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/