lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Sep 2014 19:00:30 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Anders Berg <anders.berg@...gotech.com> Cc: Mark Brown <broonie@...nel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] spi: pl022: Add support for chip select extension On Thu, Sep 11, 2014 at 10:10 PM, Anders Berg <anders.berg@...gotech.com> wrote: > On Thu, Sep 11, 2014 at 3:26 PM, Linus Walleij <linus.walleij@...aro.org> > wrote: >> On Wed, Sep 10, 2014 at 4:40 PM, Anders Berg <anders.berg@...gotech.com> >> wrote: >> (...) >> > + /* >> > + * PL022 variant that has a chip select control register >> > whih >> > + * allows control of 5 output signals nCS[0:4]. >> > + */ >> > + .id = 0x000b6022, >> >> OK so you're defining 0xb6 to the the 8bit ID for LSI. >> >> Do you have some special reason for this, like that it appears >> in some other silicon block from LSI? Otherwise I suggest using >> 0x4c (uppercase 'L') so as to follow the pattern of the other >> vendor IDs. > > > I picked 0xb6 since I've seen some reference manuals for other AMBA > peripherals the use of JEDEC assigned vendor IDs in this register field (see > the PL390 TRM for example). So I put the LSI Logic 7-bit JEDEC ID (0x36) > there: [0:6] = 0x36, [7] = 1 (the MSB set to '1' to signify the use of JEDEC > ID instead of a "classic" AMBA vendor). Hey that's very observant, I had no clue about that scheme! Can you write a comment about this in <linux/amba/bus.h> when you patch it (like above the enum) so we know that in the future when people need to pick new IDs? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists